-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add show unread notifications filter button #6356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Pranshu1902 just a suggestion
Co-authored-by: Khavin Shankar <[email protected]>
@khavinshankar @nihal467 merged the suggestions, please check again |
khavinshankar
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at ae264dc
Added a feature to filter notifications by unread status in the
NotificationsList
component. This involved adding a state variable, a button, and some conditional rendering logic insrc/Components/Notifications/NotificationsList.tsx
, as well as some translation keys insrc/Locale/en/Notifications.json
.Proposed Changes
Add show unread notifications filter button to show only unread notifications
Screencast from 27-09-23 02:09:03 PM IST.webm
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at ae264dc
showUnread
to theNotificationsList
component to toggle between showing all notifications or only unread ones (link)showUnread
state before rendering theNotificationTile
component (link)load more
button if theshowUnread
state is true, since there is no pagination for unread notifications (link)NotificationsList
component that allows the user to switch theshowUnread
state and display different icons and labels using theCareIcon
component and thet
function (link)Notifications.json
file for the button labels (link)